feat(discord): sync thread names from session titles - #26477
Conversation
|
+1 on this — clean implementation, covers both the auto-title and manual We're running Hermes with Cherry-picked this locally against current Would be great to get this reviewed and merged. This feature has been attempted 5 times in prior PRs that all got bot-staled — this one actually has clean code and tests. Closes #18430 |
|
Thanks for the focused callback-based implementation. Current main now contains the generated-title half of this behavior, but with safety constraints the PR predates. Problems
Suggested changes
Automated hermes-sweeper review. |
Summary
/title ...changes immediately when the command is run from a Discord thread.Test Plan
python -m pytest tests/gateway/test_title_command.py -qpython -m py_compile gateway/platforms/discord.py gateway/run.pyPlatforms Tested
Related / competing PRs
feat(gateway/discord): sync thread names with session titles, targets the same user-visible Discord thread/session title sync behavior. This PR supersedes it by avoiding the DB polling loop, scheduling auto-title renames directly from the title callback onto the gateway event loop, keeping the scope focused, and adding regression tests./titlerenames in the same tested path. This PR is a consolidated successor rather than another duplicate.Notes/Risks