Conversation
Collaborator
|
Thanks for the focused QQ attachment fix. The reported behavior is already implemented on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes QQ Bot document attachments so Hermes keeps the original filename and passes the cached local file path into the agent event instead of dropping the file after download.
Related Issue
Fixes #26399
Type of Change
Changes Made
gateway/platforms/qqbot/adapter.pyso non-image/non-voice attachments append their cached local path into the normalmedia_urls/media_typespipeline instead of only emitting a text marker.filenameinto_download_and_cache()and prefer it over the CDN URL basename when caching documents.tests/gateway/test_qqbot.pycovering both cached document surfacing and original-filename preservation.How to Test
python3 -m pytest -o addopts='' tests/gateway/test_qqbot.py.[Attachment: ...]text.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
python3 -m pytest -o addopts='' tests/gateway/test_qqbot.py→146 passed, 1 warning in 4.19spython3 -m py_compile gateway/platforms/qqbot/adapter.py tests/gateway/test_qqbot.pygit diff --checkuv run --extra dev --extra acp python -m pytest tests/ -q --ignore=tests/integration --ignore=tests/e2e --tb=short -x, but the environment is missing optional test dependencies outside this change (fastapion branch,aiohttpon cleanorigin/main).