fix(gateway): roll over telegram tool progress bubbles - #26242
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
Collaborator
19 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Telegram tool-progress rollover so long-running gateway turns stop editing a full progress bubble and continue from a fresh one before hitting Telegram's single-message limit. The gateway now also honors an adapter's returned replacement
message_idafter successful edits so follow-up updates keep targeting the newest visible progress message.Related Issue
Fixes #26207
Type of Change
Changes Made
gateway/run.pyfor progress-bubble sizing.message_idvalues returned byedit_message().tests/gateway/test_run_progress_topics.pycovering Telegram rollover behavior with a constrained message limit.How to Test
python3 -m pytest -o addopts='' tests/gateway/test_run_progress_topics.py.test_run_agent_telegram_progress_rolls_over_before_edit_overflowpasses.display.tool_progress: all, run a tool-heavy turn and verify progress opens a second bubble before the first one overflows.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
python3 -m pytest -o addopts='' tests/gateway/test_run_progress_topics.py→26 passed, 3 warnings in 27.89s