feat(gateway): auto-delete Discord tool progress bubbles by nazirulhafiy · Pull Request #26055 · NousResearch/hermes-agent

nazirulhafiy · 2026-05-15T02:31:15Z

Summary

This PR makes Hermes clean up Discord tool progress bubbles after they are no longer useful.

Hermes can show little “I’m working on it” messages while tools run:

💻 terminal command running
🐍 code executing
📖 file being read
🔍 search in progress
🌐 web page loading

Those bubbles are helpful while Hermes is working.

But once the final answer is delivered, they should not hang around forever like abandoned scaffolding.

This PR makes them disappear automatically after successful runs, while still preserving useful breadcrumbs when something fails.

Problem

Hermes already had progress bubbles, and Discord already had the ability to delete messages.

The missing piece was the cleanup path.

In practice, this could happen:

Hermes starts using a tool
Discord shows a progress bubble
Hermes finishes the task
The final answer appears
The old progress bubble sometimes stays behind

For users, this makes Discord channels feel noisy and stale.

For maintainers, the confusing part was that the config setting looked correct:

display.auto_delete_tool_progress: true

…but the gateway was not always tracking enough cleanup state to actually delete the bubbles later.

Solution

This PR wires progress cleanup to the setting users expect:

display.auto_delete_tool_progress: true

When enabled:

✅ progress bubbles appear while tools are running
✅ successful runs clean up their progress bubbles
✅ cleanup can survive a gateway restart
✅ Discord deletion uses the adapter’s delete_message() capability
✅ failed runs can keep breadcrumbs visible for debugging
✅ setting auto_delete_tool_progress: false preserves the old behavior

In plain English:

Hermes can show her work while she’s working, then tidy the desk when she’s done.

Technical details

This PR updates the gateway progress lifecycle so that:

display.auto_delete_tool_progress enables cleanup tracking directly
pending cleanup state is persisted for restart recovery
final cleanup paths delete progress bubbles only when appropriate
failed runs can keep visible traces instead of deleting potentially useful debugging context

Key behavior change:

auto_delete_tool_progress = true

now means both:

show progress bubbles while tools run
track them so they can actually be deleted later

Previously, those two parts could drift apart.

User-facing behavior

Successful run

💻 Tool bubble appears
✅ Hermes finishes
🧹 Tool bubble disappears

Gateway restart with pending bubbles

💻 Bubble was still pending
🔁 Gateway restarts
🧹 Startup cleanup drains stale bubbles

Failed run

💻 Bubble appears
❌ Run fails
🧭 Breadcrumb can remain for debugging

Files changed

File	Change
`gateway/platforms/discord.py`	Adds Discord message deletion support
`gateway/run.py`	Tracks and cleans up tool progress bubbles
`tests/gateway/test_progress_auto_delete.py`	Adds component coverage for progress auto-delete
`tests/gateway/test_run_cleanup_progress.py`	Adds/updates gateway cleanup path coverage

Testing

Ran targeted gateway tests:

pytest tests/gateway/test_progress_auto_delete.py       tests/gateway/test_run_cleanup_progress.py -q

Result:

16 passed

Also manually verified locally:

gateway restarted successfully
startup cleanup drained stale progress bubbles
successful tool runs no longer leave stale Discord progress bubbles behind

Breaking changes

None.

The feature is controlled by:

display.auto_delete_tool_progress

Default behavior is auto-delete enabled.

Users who prefer the old “leave progress bubbles visible” behavior can set:

display.auto_delete_tool_progress: false

Reviewer note

This PR overlaps with earlier progress cleanup work, but the current branch fixes the practical config-path gap:

display.auto_delete_tool_progress now actually causes progress bubbles to be tracked and cleaned up reliably.

So the goal is not just “Discord can delete messages.”

The goal is:

Hermes should be visibly busy while working, then clean up after herself when the work is done — not leave a raccoon trail of stale terminal bubbles across Discord.

alt-glitch · 2026-05-15T02:33:57Z

Duplicate of #18306 (same feature, same approach). Also overlaps with #21890 which adds delete_message support. Note that #21186 (opt-in cleanup of progress bubbles) is already merged — this PR may be partially redundant.

Adds delete_message() to the Discord adapter and wires it into both __reset__ handlers in the progress message loop, plus the final edit drain path. When a content bubble lands after a tool batch, the progress bubble (🔧, 📖, 💻) is now deleted instead of left orphaned in the channel, reducing chat clutter. - gateway/platforms/discord.py: new delete_message() method - gateway/run.py: delete in normal __reset__, CancelledError drain, and final-edit path — with capability gate via 'type(adapter).delete_message is not BasePlatformAdapter.delete_message'

…o-delete - Final-drain path (3rd location) now logs delete attempts and errors, matching the __reset__ handlers — so lingering bubbles are diagnosable. - Adds config key `display.auto_delete_tool_progress` (default: true). Set to `false` in config.yaml to disable progress bubble auto-deletion. - All three delete locations respect the toggle.

…eanup Bug: The __reset__ delete handler gated deletion on can_edit, which flips to False on any edit failure (e.g. Discord 429 rate limit on rapid tool calls). Once can_edit went False, every subsequent progress bubble became permanent. Fix: - Add can_delete flag alongside can_edit - Use can_delete in the __reset__ delete gate instead of can_edit - Track can_delete = False only when delete_message() actually fails, not when edit fails - Apply same failure tracking to CancelledError drain and final drain delete paths This ensures Discord rate-limiting an edit mid-session no longer disables progress bubble deletion.

…o-delete Adds 8 tests covering: - Capability check: overridden vs base adapter delete_message detection - Adapter behavior: success, failure, and multiple sequential calls - Config resolution: auto_delete_tool_progress default, explicit off, and per-platform overrides via display_config Pragmatic approach: tests verify the component pieces directly (capability checks, adapter contract, config resolver) rather than requiring a full _run_agent integration test, since the delete code path requires an active Discord adapter + live agent loop that doesn't map cleanly to the mock-based test harness. Part of PR #18306.

…nterrupt Bug: When the agent finishes normally (not interrupted/cancelled), _run_still_current() returned False and send_progress_messages() exited via early return at the top of the main loop body. This bypassed the CancelledError handler where the delete calls live, so tool progress bubbles (e.g. ⏰ cronjob) lingered permanently in Discord. Fix: Added delete logic at the early-return site (normal completion) matching the existing pattern in the CancelledError drain handler. All three exit paths now clean up: normal completion, __reset__ drain, and final-drain. Part of PR #18306.

- Add delete to first _run_still_current() check (race: run completes before __reset__ signal arrives). Tagged (run-completed). - Move __reset__ delete outside can_edit gate (Discord supports delete even when edit fails). Fixes nested-gate bug May 2026.

- Add pending_progress_cleanup.json queue at ~/.hermes/gateway/ - Record (platform, chat_id, message_id) on bubble creation - Clear record on successful delete (4 existing paths + startup drain) - Retry failed deletes up to 5 attempts - GatewayRunner.start() drains stale records after adapter connect - Add TestPersistedProgressCleanup (3 tests: round-trip, startup success, startup failure retries) Extends PR #18306 (auto-delete tool progress bubbles).

…w() with timezone-aware alternative; B2: unify auto_delete_tool_progress config source via resolve_display_setting

austinpickett

Please use .github/PULL_REQUEST_TEMPLATE.md and fix merge conflicts

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

alt-glitch added type/feature New feature or request comp/gateway Gateway runner, session dispatch, delivery platform/discord Discord bot adapter P3 Low — cosmetic, nice to have labels May 15, 2026

nazirulhafiy mentioned this pull request May 15, 2026

feat(gateway): Discord tool progress bubbles auto-delete when job is done #18306

Closed

20 tasks

github-actions Bot mentioned this pull request May 15, 2026

🦞 OpenClaw 生态日报 2026-05-15 ivanweng2077/big_model_radar#46

Open

nazirulhafiy requested a review from a team May 17, 2026 02:32

github-actions Bot mentioned this pull request May 17, 2026

🦞 OpenClaw 生态日报 2026-05-17 ivanweng2077/big_model_radar#55

Open

nazirulhafiy added 13 commits May 17, 2026 10:55

fix(gateway): strip unrelated /raw command from this PR

77dc749

feat(gateway): auto-delete Discord tool progress bubbles

6d37c65

fix(tests): stabilize CI fixtures for progress cleanup

93efcfa

fix: address Athena PR review — B1: replace deprecated datetime.utcno…

1ffa895

…w() with timezone-aware alternative; B2: unify auto_delete_tool_progress config source via resolve_display_setting

fix: make auto_delete_tool_progress enable cleanup tracking

bedb997

fix: restore send command plumbing

a1b7f2e

austinpickett requested a review from Copilot May 19, 2026 12:42

Copilot started reviewing on behalf of austinpickett May 19, 2026 12:42 View session

This comment was marked as duplicate.

Sign in to view

austinpickett requested changes May 19, 2026

View reviewed changes

Copilot AI reviewed May 19, 2026

austinpickett requested a review from Copilot May 19, 2026 13:12

Copilot started reviewing on behalf of austinpickett May 19, 2026 13:12 View session

Copilot AI reviewed May 19, 2026

Copilot stopped reviewing on behalf of austinpickett due to an error May 19, 2026 13:14
An unexpected error occurred. For more details, see the detailed logs in GitHub Actions.

alt-glitch mentioned this pull request May 23, 2026

fix(discord): support progress message cleanup #30801

Open

nazirulhafiy closed this by deleting the head repository May 27, 2026

Navigation Menu

feat(gateway): auto-delete Discord tool progress bubbles - #26055

feat(gateway): auto-delete Discord tool progress bubbles#26055
nazirulhafiy wants to merge 13 commits into
NousResearch:mainfrom
nazirulhafiy:feat/delete-progress-bubble-clean

nazirulhafiy commented May 15, 2026 •

edited

Loading

Uh oh!

alt-glitch commented May 15, 2026

Uh oh!

This comment was marked as duplicate.

Uh oh!

austinpickett left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nazirulhafiy commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Technical details

User-facing behavior

Successful run

Gateway restart with pending bubbles

Failed run

Files changed

Testing

Breaking changes

Reviewer note

Uh oh!

alt-glitch commented May 15, 2026

Uh oh!

This comment was marked as duplicate.

Uh oh!

austinpickett left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nazirulhafiy commented May 15, 2026 •

edited

Loading