Conversation
This was referenced May 31, 2026
Collaborator
|
Thanks for isolating the classic-CLI dispatch gap. The premise is still valid on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
This was referenced Jul 30, 2026
Closed
1 task
Collaborator
|
Merged via PR #90381 — your commit was cherry-picked onto current main with your authorship preserved in git log. Thanks for the fix, and for being the earliest of four independent submissions for this bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Classic CLI help and completion surfaced
/whoamifrom the shared command registry,but
HermesCLI.process_command()had no dispatch branch for it.This change wires
/whoamiinto the classic CLI and adds regression coverage so itno longer falls through to
Unknown command.What changed
/whoamihandler incli.pycanonical == "whoami"through the main slash-command dispatchertests/cli/test_cli_init.pyUser impact
Before:
/whoamiappeared to exist in classic CLI surfacesUnknown command: /whoamiAfter:
/whoamiprints local CLI access info as expectedTesting
Passed:
pytest tests/cli/test_cli_init.py -k whoamiEnvironment: