Skip to content

fix(ci): add checks: write permissions to resolve blocked fork PRs - #26018

Closed
am423 wants to merge 1 commit into
NousResearch:mainfrom
am423:fix/ci-permissions-fork-prs
Closed

fix(ci): add checks: write permissions to resolve blocked fork PRs#26018
am423 wants to merge 1 commit into
NousResearch:mainfrom
am423:fix/ci-permissions-fork-prs

Conversation

@am423

@am423 am423 commented May 15, 2026

Copy link
Copy Markdown
Contributor

This PR adds explicit checks: write (and pull-requests: write where appropriate) permissions to all PR-relevant GitHub Actions workflows.

Problem

PRs opened from forks currently show no CI checks and appear as BLOCKED. This was noted on #25968:

현재 체크가 없고 BLOCKED 상태입니다. CI/권한 상태를 확인한 뒤 다시 봐야 합니다.

Root Cause

GitHub runs workflows from fork PRs with a restricted GITHUB_TOKEN. Without checks: write, jobs cannot report status checks.

Fix

Updated the following workflows:

  • tests.yml
  • lint.yml
  • contributor-check.yml
  • supply-chain-audit.yml
  • nix.yml
  • uv-lockfile-check.yml
  • docs-site-checks.yml
  • nix-lockfile-fix.yml

This is a small infrastructure change that should allow CI to run and report properly on external contributions going forward, including the first-class xAI (Grok) OAuth provider work in #25968.

…flows

This fixes 'no checks / BLOCKED' state on PRs opened from forks.

GitHub requires explicit 'checks: write' permission for workflows
to report status checks when triggered from fork PRs. Previously
most workflows only had 'contents: read', which left them unable
to post check results → PR appeared blocked with no CI output.

Affected workflows (all PR-relevant ones):
- tests.yml
- lint.yml
- contributor-check.yml
- supply-chain-audit.yml
- nix.yml
- uv-lockfile-check.yml
- docs-site-checks.yml
- nix-lockfile-fix.yml

This should resolve the blocked CI comment on PR NousResearch#25968.
@am423

am423 commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Recommended labels for this PR:

  • area/config
  • P3
  • type/refactor

These should help maintainers quickly triage it. This is a small CI permissions fix to unblock fork PRs (including the first-class xAI OAuth work in #25968).

@maintainers — could you please add the above labels? Thanks!

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have labels May 15, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thank you for investigating the blocked-checks problem. This is an automated hermes-sweeper review; current main now implements the required-status guarantee through a different CI architecture.

  • .github/workflows/ci.yml:13-23 is the current pull-request entrypoint and central permission boundary; the former PR-specific workflows are now reusable workflow_call lanes (ci.yml:57-129).
  • .github/workflows/ci.yml:137-167 defines the all-checks-pass aggregate gate with if: always(), so skipped lanes still yield a required-check result rather than remaining pending.
  • Commit 05c896cf524991f95c34ce73d2cbe985b5e0558f introduced that orchestrator and aggregate gate. Commit 9eb0bcd60fc6d3fe28e0b1c5bbe188f94169f65c also removed both Nix workflows changed by this PR.

The PR is currently conflicting against this newer workflow layout, so its permission-only patch is superseded by the implementation on main.

@teknium1 teknium1 closed this Jul 13, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants