Conversation
Contributor
|
Duplicate of #8205 which is the most comprehensive TTS preprocessing PR (strips markdown, localizes 28 emojis across 13 languages). Also overlaps with #13311 and #18598. Additionally, this PR contains 8 unrelated file changes (.env.example, sync.yml, auxiliary_client.py, codex.py, gateway/run.py, config.py, dashboard dist, run_agent.py) beyond the TTS scope. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_strip_markdown_for_ttsonly handled basic markdown (bold/italic/headers/lists/code-fences/links) but left through everything that TTS engines (edge, kokoro, piper, xtts) read as garbage: emoji, dingbats, box-drawing diagrams, geometric shapes, arrows, math operators, and ASCII divider lines.Symptoms reported in production:
┌─┐ │ box │ └─┘→ long awkward pauses with "box" mangledcode→ identifiers pronounced character-by-characterThis patch extends the function to also drop:
>The original chat output is untouched — the function runs only on the copy passed to the TTS engine. Telegram/Discord/terminal messages remain visually formatted; only the spoken reply gets clean prose.
Test plan