Skip to content

feat: add Zed ACP registry integration - #25908

Closed
am423 wants to merge 1 commit into
NousResearch:mainfrom
am423:feat/acp-registry-zed
Closed

feat: add Zed ACP registry integration#25908
am423 wants to merge 1 commit into
NousResearch:mainfrom
am423:feat/acp-registry-zed

Conversation

@am423

@am423 am423 commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • adds registry-compatible Hermes ACP metadata and 16x16 currentColor icon
  • adds terminal setup auth method for clean first-run ACP Registry validation
  • adds ACP --version/--check/--setup paths and an npm launcher package for Zed registry installs
  • updates ACP docs and adds focused manifest/auth/launcher tests

Test Plan

  • source venv/bin/activate; python -m pytest tests/acp/test_auth.py tests/acp/test_server.py tests/acp/test_entry.py tests/acp/test_registry_manifest.py -q
  • cd packages/hermes-agent-acp && npm test && npm pack --dry-run
  • python -m hermes_cli.main acp --version && python -m hermes_cli.main acp --check
  • SKIP_URL_VALIDATION=1 uv run --with jsonschema .github/workflows/build_registry.py --dry-run in agentclientprotocol/registry with Hermes files copied into top-level hermes-agent/
  • local ACP auth smoke with registry client: authMethods includes hermes-setup(terminal)
  • npm run build in website (passes with pre-existing Docusaurus warnings/broken links)

Known follow-up before upstream ACP registry PR

  • publish @nousresearch/hermes-agent-acp@0.13.0 or the next release version; local registry validation without SKIP_URL_VALIDATION fails until that npm package exists
  • run the official registry auth check against the published package before submitting agentclientprotocol/registry PR

@am423
am423 requested a review from a team May 14, 2026 19:44
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/acp Agent Communication Protocol adapter labels May 14, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Merged via #26079 with your authorship preserved via cherry-pick (commit 5149468). Thanks for the thorough work — registry-schema manifest, terminal-setup auth method, npm launcher package, and the doc updates all landed as-is.

I added one follow-up commit on top (aa56900): a release-script hook in scripts/release.py that bumps acp_registry/agent.json, packages/hermes-agent-acp/package.json, and the launcher's HERMES_AGENT_VERSION in lockstep with pyproject.toml, so the next weekly version bump won't trip test_agent_json_version_matches_pyproject.

As you flagged in the PR body, the upstream agentclientprotocol/registry submission still needs us to publish @nousresearch/hermes-agent-acp@ to npm first — that's the gating ops step before the registry PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/acp Agent Communication Protocol adapter P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants