Fix dashboard session list payload size - #25628
Closed
yalru9406-create wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Thanks for digging into the session-list payload problem — the diagnosis (list rows carrying the full Closing this one because the implementation has drifted too far from current main to salvage directly:
The payload fix is being consolidated from the newer PRs in this cluster (#43653's field-strip + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- return lightweight metadata from /api/sessions instead of full session rows\n- clamp dashboard session list limits to avoid oversized refreshes\n- add regression coverage for excluding large/private fields from list responses\n\n## Verification\n- PYTHONPATH=. venv/bin/python -m pytest tests/hermes_cli/test_web_server_sessions_api.py tests/hermes_cli/test_web_server_host_header.py tests/hermes_cli/test_dashboard_browser_safe_imports.py -q\n- live dashboard smoke: /api/sessions?limit=20 is ~7.7KB; limit=50 is ~19KB; limit=200 clamps to 100 rows / ~38KB\n- Playwright UX smoke: console errors 0, page errors 0, failed requests 0\n