fix(ui-tui): skip generic path segments when deriving slug fallback labels (#25606)

[briandevans]

What does this PR do?

TUI link labels collapsed to a single generic word ("Status", "Auth", …) when title resolution fell back to urlSlugTitleLabel(), masking which destination was linked. Extends the same-shape skip used for numeric-only segments to cover a small set of generic single-word path segments, so the loop continues to a more informative segment or falls through to hostPathLabel.

PR #24013 introduced ResolvedLink + useLinkTitle() in ui-tui/src/components/markdown.tsx. When the async <title> fetch fails or is skipped (local/private hosts, non-HTML responses, errors), the display falls back to defaultLinkLabel → urlSlugTitleLabel(url). urlSlugTitleLabel() iterates path segments in reverse, already skipping pure-numeric segments, but accepts the first segment with a letter and length ≥ 4, including obviously generic trailing words like status, auth, item. The Web UI shows the full clickable URL in the same case.

After the fix: https://x.com/OpenAI/status/1234567890 → OpenAI; https://accounts.google.com/o/oauth2/auth → accounts.google.com/o/oauth2/auth; https://news.ycombinator.com/item → news.ycombinator.com/item. Multi-word and domain-specific segments (issues, releases, pulls, commit, …) are left alone so existing readable slugs keep working.

Related Issue

Fixes #25606

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ New feature (non-breaking change that adds functionality)
• 🔒 Security fix
• 📝 Documentation update
• ✅ Tests (adding or improving test coverage)
• ♻️ Refactor (no behavior change)
• 🎯 New skill (bundled or hub)

Changes Made

• ui-tui/src/lib/externalLink.ts — add GENERIC_PATH_SEGMENT_RE regex (status/auth/oauth/signin/signup/login/page/index/home/post/tweet/view/show/detail/comment/share/embed/dashboard/profile/account/settings/item/callback/redirect…) and a continue skip sibling to the existing numeric-only skip in urlSlugTitleLabel().
• ui-tui/src/__tests__/externalLink.test.ts — 2 new cases covering the three URL classes above.

How to Test

1. From ui-tui/: npx vitest run src/__tests__/externalLink.test.ts — 12/12 pass.
2. Full ui-tui suite: npx vitest run (after building packages/hermes-ink) — 722/722 pass across 65 files.
3. Type check: npm run type-check — clean.
4. Regression guard: revert the production line; the two new tests fail with "Status" and "Auth". Restore — green.
5. Existing fixture urlSlugTitleLabel('https://www.getyourguide.com/.../from-fajardo-icacos-island-full-day-catamaran-trip-t19891/') still returns From Fajardo Icacos Island Full Day Catamaran Trip — readable multi-word slug unaffected.

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix/feature (no unrelated commits)
• I've run focused tests for the touched code and all pass (722/722 + type-check clean)
• I've added tests for my changes (required for bug fixes, strongly encouraged for features)
• I've tested on my platform: macOS 15.x

Documentation & Housekeeping

• I've updated relevant documentation (README, docs/, docstrings) — N/A
• I've updated cli-config.yaml.example if I added/changed config keys — N/A
• I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — N/A
• I've considered cross-platform impact (Windows, macOS) per the compatibility guide — TypeScript regex, platform-independent
• I've updated tool descriptions/schemas if I changed tool behavior — N/A

Related / Positioning

• Fixes [Bug]: TUI shows slug text instead of original URL #25606.
• Follow-on to feat(ui-tui): resolve markdown links to readable page titles #24013 which introduced the slug-fallback path.

Sibling code paths that may need the same fix: ui-tui/src/lib/externalLink.ts:hostPathLabel returns the bare host+path for the final fallback, which is what we want — no widening needed there. If anything ever calls urlSlugTitleLabel() from outside the markdown renderer, this guard applies uniformly. Happy to widen if preferred.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds filtering of generic path segments (e.g., status, auth, login) when deriving a human-readable title from a URL slug, so that meaningful preceding segments surface instead of uninformative ones.

Changes:

• Introduce GENERIC_PATH_SEGMENT_RE to match common generic URL path segments.
• Skip these segments in urlSlugTitleLabel, falling back to host+path when no useful slug is found.
• Add tests covering the new behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
ui-tui/src/lib/externalLink.ts	Adds generic-segment regex and skip logic in urlSlugTitleLabel.
ui-tui/src/tests/externalLink.test.ts	Adds tests for generic-segment skipping and host+path fallback.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[briandevans]

Rebased onto current main. Dropped the x.com/OpenAI/status/N → OpenAI test case because main's 7321b3c2d (fix(tui): keep x status citation fallbacks link-like) intentionally short-circuits x.com/status permalinks to hostPathLabel before any generic-skip logic runs — that's a deliberate design choice. The remaining tests (accounts.google.com/o/oauth2/auth, news.ycombinator.com/item) still exercise the generic-skip path. All 12 tests pass locally.

[briandevans]

Housekeeping: closing to keep my open-PR set focused on actively-reviewed work. This has been open ~18d without maintainer review and the surrounding code has continued to move, so it's unlikely to land as-is. The underlying fix still stands — happy to reopen and rebase if it would be useful. Thanks!