Skip to content

fix(browser): rewrite Camofox Docker loopback URLs - #25541

Merged
benbarclay merged 1 commit into
NousResearch:mainfrom
wysie:fix/camofox-docker-loopback-rewrite
May 29, 2026
Merged

fix(browser): rewrite Camofox Docker loopback URLs#25541
benbarclay merged 1 commit into
NousResearch:mainfrom
wysie:fix/camofox-docker-loopback-rewrite

Conversation

@wysie

@wysie wysie commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add opt-in Camofox Docker loopback URL rewriting for page navigation URLs
  • Preserve CAMOFOX_URL as the host-side control API while rewriting localhost/127.0.0.1/::1 page URLs to a configurable host alias
  • Document the Docker networking gotcha and add regression coverage

Test Plan

  • python -m pytest tests/tools/test_browser_camofox.py -q
  • python -m pytest tests/tools/test_browser_camofox.py tests/tools/test_browser_camofox_state.py tests/tools/test_browser_camofox_persistence.py -q
  • python -m compileall -q tools/browser_camofox.py hermes_cli/config.py cli.py
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have tool/browser Browser automation (CDP, Playwright) area/docker Docker image, Compose, packaging labels May 14, 2026
@benbarclay
benbarclay merged commit a0fc3df into NousResearch:main May 29, 2026
14 of 15 checks passed
KKT-OPT pushed a commit to KKT-OPT/hermes-agent that referenced this pull request May 31, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
alt-glitch pushed a commit that referenced this pull request Jun 14, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request Jun 18, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request Jul 13, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
Co-authored-by: Wysie <wysie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker Docker image, Compose, packaging P3 Low — cosmetic, nice to have tool/browser Browser automation (CDP, Playwright) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants