fix(cli): support Windows paste in setup secret prompts - #25540
Open
VinceZcrikl wants to merge 1 commit into
Open
VinceZcrikl wants to merge 1 commit into
VinceZcrikl wants to merge 1 commit into
Conversation
Author
Author
|
Edition Windows 11 Pro |
VinceZcrikl
force-pushed
the
fix/windows-setup-secret-paste
branch
from
June 5, 2026 23:28
96d74ee to
d4c583d
Compare
Author
|
Resolved the merge conflicts on this PR. What changed:
Validation:
GitHub now reports |
Collaborator
|
Thanks for preserving the existing masked-secret architecture and adding the Windows prompt_toolkit path. The underlying issue remains present on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix Windows setup/gateway secret prompts so pasted Telegram bot tokens and other hidden inputs can be entered reliably.
Problem
hermes setup and hermes gateway setup collect secret values through getpass.getpass(). On Windows, that path does not reuse the main CLI's prompt_toolkit paste handling, so Ctrl+V appears to do nothing in hidden prompts such as the Telegram bot token field.
Root cause
What changed
ead_line() and
ead_secret_line() helpers.
ead_secret_line() now uses a hidden prompt_toolkit prompt with Ctrl+V and bracketed paste handling.
Scope
This PR intentionally fixes the setup/gateway secret-prompt path only. It does not refactor every other getpass call site in the CLI.
Verification
Why this is not a duplicate
This is not the same as the existing work that strips bracketed-paste markers after input is already read, or the Windows getpass control-character sanitization work. This change addresses the missing paste-capable hidden-input path for Windows setup prompts themselves.