fix(tools-config): write video_gen.provider on Reconfigure tool path

[teknium1]

Summary

Reconfigure tool → Video Generation → pick xAI silently no-op'd when the relevant env var (XAI_API_KEY) was already set. The video_gen config block was never written, so the video_generate tool kept reporting "No video generation backend is configured" even though the picker had visibly accepted the selection.

Root cause

_reconfigure_provider() in hermes_cli/tools_config.py mirrors most of the first-time _configure_provider() flow but is missing the video_gen_plugin_name branch in BOTH code paths:

• the no-env-vars early-return branch (around line 2468)
• the post-env-vars branch (around line 2499)

It handles image_gen_plugin_name and imagegen_backend correctly in both spots; video_gen_plugin_name was just never added. The first-time configure path on the same provider row works fine — it routes to _select_plugin_video_gen_provider() which writes video_gen.provider, video_gen.use_gateway, and prompts for a model. Reconfigure dropped that.

Repro (current main)

1. hermes tools → Configure for All Platforms → enable Video Generation.
2. hermes tools → Reconfigure tool → Video Generation.
3. Pick xAI (with XAI_API_KEY already in ~/.hermes/.env).
4. Press Enter at the "keep current key?" prompt.

Expected: video_gen: block lands in ~/.hermes/config.yaml.
Actual: function returns; no block written; video_generate tool errors with No video generation backend is configured. Run hermes tools -> Video Generation to enable one (xAI, FAL, or Google Veo).

Fix

Add the missing video_gen_plugin_name branch in both code paths of _reconfigure_provider(), mirroring how image_gen_plugin_name is already handled and how the first-time configure flow already routes for video_gen.

video_plugin = provider.get("video_gen_plugin_name")
if video_plugin:
    _select_plugin_video_gen_provider(video_plugin, config)
    return

Tests

tests/hermes_cli/test_video_gen_picker.py — two new tests:

• test_reconfigure_with_env_vars_already_set_writes_provider — env vars present, user keeps current value, verifies video_gen.provider/model/use_gateway land. This is the actual user-hit failure path.
• test_reconfigure_with_no_env_vars_writes_provider — managed-style plugin with no env vars, verifies the no-env-vars branch.

Both follow the pattern of the existing test_reconfiguring_plugin_provider_writes_provider_and_model in test_image_gen_picker.py.

Targeted run (4 workers, hermetic):

tests/hermes_cli/test_video_gen_picker.py::TestReconfigureWritesProvider::test_reconfigure_with_env_vars_already_set_writes_provider PASSED
tests/hermes_cli/test_video_gen_picker.py::TestReconfigureWritesProvider::test_reconfigure_with_no_env_vars_writes_provider PASSED

Full image_gen/tools_config/video_gen picker test surface (79 tests including pre-existing) — all green, no regressions.

Scope

Targeted fix only. Doesn't touch the first-time configure path (already correct), doesn't touch the image_gen handling (already correct), doesn't refactor the duplicated branches into a helper — that's a separate cleanup.

[github-actions]

🔎 Lint report: fix/reconfigure-video-gen-plugin vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8299 on HEAD, 8298 on base (🆕 +1)

🆕 New issues (1):

Rule	Count
unresolved-import	1

First entries

tests/hermes_cli/test_video_gen_picker.py:13: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`

✅ Fixed issues: none

Unchanged: 4375 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.