Repository navigation
Conversation
Sertug17
force-pushed
the
fix/mistral-422-reasoning-param-v2
branch
from
March 1, 2026 10:27
6553e0e to
d4b30e5
Compare
Sertug17
force-pushed
the
fix/mistral-422-reasoning-param-v2
branch
from
March 1, 2026 10:29
d4b30e5 to
47e3e2b
Compare
Expri-commits
pushed a commit
to Expri-commits/hermes-agent
that referenced
this pull request
Sep 3, 2026
- Added 'i want to' pattern (catches 'I want to know it will stay there...') - Added 'you should' pattern (catches instructions) - Made gate more surgical to avoid blocking legitimate facts like 'User prefers...' - Focuses on actual leaks: 'I need to...', 'I want to know...', conversational fragments - Applies to both on_memory_write and auto_extract gates Blocked the main leaks: NousResearch#242, NousResearch#252, NousResearch#253, NousResearch#224, NousResearch#232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #134
When using Mistral API directly (api.mistral.ai), the agent sends a
reasoningparameter inextra_bodythat Mistral does not support. This causes HTTP 422 "Unprocessable Entity" errors.Root Cause
In
run_agent.py, thereasoningparameter is only guarded by:However, if a user routes through OpenRouter but selects a Mistral model, or connects directly to
api.mistral.ai, this parameter is still sent and rejected.Fix
Added
_is_mistraldetection and excluded it from receiving thereasoningparam:Testing
Verified the fix prevents
reasoningfrom being added toextra_bodywhen base URL containsapi.mistral.ai.