Conversation
Contributor
This was referenced May 16, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kanban tasks created through the tool path could finish or block silently because they never received gateway notification subscriptions.
Slash-command-created tasks already call
add_notify_sub(...), but orchestrator/worker fan-out goes throughtools/kanban_tools.py::_handle_create, which previously only created the task row. That leftkanban_notify_subsempty, so the gateway notifier had no destination when the task reached a terminal state.This PR adds notification setup to tool-created tasks and preserves subscriptions across child-task fan-out.
Changes
_ensure_notify_subscriptions(...)intools/kanban_tools.py.kanban_notify_subsrows onto newly created child tasks.gateway.session_context.get_session_env(...)and subscribe the origin platform/chat/thread.AUTHOR_MAPentry for contributor attribution check (scripts/release.py).Validation
scripts/run_tests.sh tests/tools/test_kanban_tools.py::test_create_auto_subscribes_origin_in_gateway_session tests/tools/test_kanban_tools.py::test_create_child_inherits_parent_notify_subscriptions tests/tools/test_kanban_tools.py::test_create_no_subscription_without_parent_or_session tests/hermes_cli/test_kanban_notify.py -q13 passed in 12.56sNotes
kanban_notify_substable and notifier flow.