fix(gateway): Mattermost Thread and Command Handling Fixes - #25187
Closed
JoshuaBowerman wants to merge 5 commits into
Closed
fix(gateway): Mattermost Thread and Command Handling Fixes#25187JoshuaBowerman wants to merge 5 commits into
JoshuaBowerman wants to merge 5 commits into
Conversation
…tep mobile app restrictions preventing sending messages beginning with a /
…termost to side step mobile app restrictions preventing sending messages beginning with a /
… feature/mattermost-bug-fixes
Collaborator
Contributor
|
Thanks for the focused Mattermost coverage. This is now implemented on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the mattermost thread handling to properly choose the thread's root id.
It also changes the mattermost command handling code to accept commands preceded by a single space character.
Related Issue
Fixes #25181
Fixes #25184
Type of Change
Changes Made
gateway/platforms/base.py- uses thread_id if available.gateway/platforms/mattermost.py- Allows prefixed ' ' character in commands for mattermost.tests/gateway/test_mattermost.py- Tests for changed behaviour.How to Test
/helpto a channel/helpas a reply to the bot reply.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass