fix(models): prioritize Ollama Cloud models - #25174
Open
farena-ai wants to merge 1 commit into
Open
Conversation
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for improving the Ollama Cloud picker. The requested behavior is still absent on current main: fetch_ollama_cloud_models() preserves live/models.dev order at hermes_cli/models.py:3746-3761.
Problems
- The new priority call in this PR only handles a newly merged result. Current fresh-cache returns at
hermes_cli/models.py:3720-3724and stale-cache fallback athermes_cli/models.py:3763-3766return stored order verbatim, so existing caches and offline fallback do not receive the requested prioritization.
Suggested changes
- Apply the helper on both cache-return paths, or centralize it before every return from
fetch_ollama_cloud_models(). - Add tests for fresh-cache and stale-cache ordering alongside the new merge test.
Automated hermes-sweeper review.
| @@ -3146,6 +3180,7 @@ def fetch_ollama_cloud_models( | |||
| seen.add(normalized) | |||
Contributor
There was a problem hiding this comment.
This reorders only newly merged results. Fresh-cache and stale-cache paths return their stored lists verbatim on current main (hermes_cli/models.py:3720-3724, 3763-3766), so please apply the helper to those return paths too and cover them with tests.
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files changed
hermes_cli/models.pytests/hermes_cli/test_ollama_cloud_provider.pyTest commands/results
Result:
Live impact
Restart/reload needed
Known caveats