fix(web): use Node.js for sync-assets instead of Unix rm/cp - #25090
Closed
ms-alan wants to merge 1 commit into
Closed
fix(web): use Node.js for sync-assets instead of Unix rm/cp#25090ms-alan wants to merge 1 commit into
ms-alan wants to merge 1 commit into
Conversation
sync-assets used Unix rm which is not available on Windows CMD/PowerShell. Replace with a small Node.js script using built-in fs APIs. Closes NousResearch#25073
alt-glitch
added
type/bug
Collaborator
This was referenced May 14, 2026
This was referenced May 14, 2026
Contributor
|
Closing in favor of the broader fix in #25983 (#25983), which addresses the same sync-assets cross-platform bug plus two related Windows issues (silent npm failures and cp1252 console crashes) from @johnisag's earlier PR #13368. Thanks for spotting the bug — your fix was correct on its own, the merged version just covers more ground. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync-assets used Unix rm which is not available on Windows CMD/PowerShell, causing the web UI build to fail with 'rm is not recognized'.
Replace with a small Node.js script (web/scripts/sync-assets.js) that uses Node.js built-in fs APIs for cross-platform file operations.
Changes
Closes #25073