fix(cron): sanitize invisible unicode in assembled prompts - #25002
Closed
kimireg wants to merge 1 commit into
Closed
fix(cron): sanitize invisible unicode in assembled prompts#25002kimireg wants to merge 1 commit into
kimireg wants to merge 1 commit into
Conversation
Strip Unicode format-control characters from cron prompts before scanning and execution. This prevents benign external content such as emoji joiners in script output from blocking scheduled jobs, while still exposing hidden prompt-injection text to the scanner.
Contributor
|
This has been implemented on current main by a later maintainer fix. This is an automated hermes-sweeper review. Evidence:
One intentional difference from this PR: current main keeps raw user-authored cron prompts strict-blocking on invisible Unicode, and only sanitizes vetted/runtime-loaded assembled content. That preserves the security posture while fixing the false-positive cron failure mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python -m pytest tests/cron/test_cron_prompt_injection_skill.pypython -m py_compile cron/scheduler.py tools/cronjob_tools.py tests/cron/test_cron_prompt_injection_skill.pygit diff --checkpython -m pytest tests/cron