Skip to content

fix(agent): strip finish_reason and internal fields before API calls #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bartok9 wants to merge 1 commit into from
Closed

fix(agent): strip finish_reason and internal fields before API calls #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2271,9 +2271,9 @@ def flush_memories(self, messages: list = None, min_turns: int = None):
reasoning = msg.get("reasoning")
if reasoning:
api_msg["reasoning_content"] = reasoning
api_msg.pop("reasoning", None)
api_msg.pop("finish_reason", None)
api_msg.pop("_flush_sentinel", None)
# Remove internal-only fields (not part of API schema)
for internal_field in ("reasoning", "finish_reason", "_flush_sentinel"):
api_msg.pop(internal_field, None)
api_messages.append(api_msg)

if self._cached_system_prompt:
Expand Down Expand Up @@ -2640,7 +2640,14 @@ def _handle_max_iterations(self, messages: list, api_call_count: int) -> str:
messages.append({"role": "user", "content": summary_request})

try:
api_messages = messages.copy()
# Build API messages, stripping internal-only fields
api_messages = []
for msg in messages:
api_msg = msg.copy()
for internal_field in ("reasoning", "finish_reason"):
api_msg.pop(internal_field, None)
api_messages.append(api_msg)

effective_system = self._cached_system_prompt or ""
if self.ephemeral_system_prompt:
effective_system = (effective_system + "\n\n" + self.ephemeral_system_prompt).strip()
Expand Down Expand Up @@ -2911,13 +2918,12 @@ def run_conversation(
# Add reasoning_content for API compatibility (Moonshot AI, Novita, OpenRouter)
api_msg["reasoning_content"] = reasoning_text

# Remove 'reasoning' field - it's for trajectory storage only
# We've copied it to 'reasoning_content' for the API above
if "reasoning" in api_msg:
api_msg.pop("reasoning")
# Remove finish_reason - not accepted by strict APIs (e.g. Mistral)
if "finish_reason" in api_msg:
api_msg.pop("finish_reason")
# Remove internal-only fields that aren't part of the API schema.
# - 'reasoning': trajectory storage only (copied to reasoning_content above)
# - 'finish_reason': response metadata, not a valid request field
# Some providers (e.g., Mistral) reject extra fields with 422 errors.
for internal_field in ("reasoning", "finish_reason"):
api_msg.pop(internal_field, None)
# Keep 'reasoning_details' - OpenRouter uses this for multi-turn reasoning context
# The signature field helps maintain reasoning continuity
api_messages.append(api_msg)
Expand Down