fix: preserve Xiaomi MiMo thinking blocks - #24893
Closed
hirogen317 wants to merge 2 commits into
Closed
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.xiaomimimo.com/anthropic.reasoning_content-derived thinking blocks for Xiaomi MiMo replay turns, matching the existing Kimi/DeepSeek strip-signed/keep-unsigned policy.Test Plan
python -m pytest --tb=short -q tests/agent/test_xiaomi_mimo_anthropic_thinking.pyfailed with missing detector / thinking blocks stripped./Users/gen/.hermes/hermes-agent/venv/bin/python -m pytest --tb=short -q tests/agent/test_xiaomi_mimo_anthropic_thinking.py tests/agent/test_deepseek_anthropic_thinking.py→ 18 passed./Users/gen/.hermes/hermes-agent/venv/bin/python -m pytest --tb=short -q tests/agent/test_xiaomi_mimo_anthropic_thinking.py tests/agent/test_deepseek_anthropic_thinking.py tests/agent/test_kimi_coding_anthropic_thinking.py→ 35 passed./Users/gen/.hermes/hermes-agent/venv/bin/python -m ruff check agent/anthropic_adapter.py tests/agent/test_xiaomi_mimo_anthropic_thinking.py→ All checks passed.Docker / containerization
docker build -t hermes-agent:issue-24884 .was attempted but failed before project build steps while resolvingdebian:13.4from Docker Hub due local Docker proxy DNS (lookup http.docker.internal ... connection refused). This appears environment/network-related rather than code-related.Closes #24884