fix: read auxiliary.vision.model from config.yaml in vision/browser tools - #24872
Closed
vanthinh6886 wants to merge 1 commit into
Closed
fix: read auxiliary.vision.model from config.yaml in vision/browser tools#24872vanthinh6886 wants to merge 1 commit into
vanthinh6886 wants to merge 1 commit into
Conversation
…ools vision_analyze, browser_vision, and video_analyze tools only read the vision model from the AUXILIARY_VISION_MODEL environment variable, ignoring the auxiliary.vision.model setting in config.yaml. When users configure a custom vision model via config.yaml (e.g. auxiliary.vision.model: nvidia/nemotron-3-nano-omni-30b-a3b-reasoning:free), the tools would still use the auto-detected default (often Gemma from Nous Portal free tier), making it impossible to work around rate limits. Fix: each tool now reads from config.yaml as fallback when the env var is not set. Resolution order: env var > config.yaml > None (auto-detect). Files changed: - tools/browser_tool.py: _get_vision_model() now reads auxiliary.vision.model - tools/vision_tools.py: _handle_vision_analyze and _handle_video_analyze now read auxiliary.vision.model / auxiliary.video.model from config Fixes NousResearch#24842
Collaborator
4 tasks
Contributor
Contributor
|
Thanks for the focused configuration-routing fix. This is an automated hermes-sweeper review; current
|
This was referenced Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vision_analyze,browser_vision, andvideo_analyzetools only read the vision model from theAUXILIARY_VISION_MODELenvironment variable, ignoring theauxiliary.vision.modelsetting inconfig.yaml.When users configure a custom vision model via config.yaml:
The tools still use the auto-detected default (often
google/gemma-4-31b-it:freefrom Nous Portal free tier), making it impossible to work around rate limits by switching to a different vision model.Fix
Each tool now reads from
config.yamlas fallback when the env var is not set.Resolution order: env var (
AUXILIARY_VISION_MODEL) >auxiliary.vision.modelin config.yaml >None(lets auxiliary router auto-detect)Files changed:
tools/browser_tool.py:_get_vision_model()now readsauxiliary.vision.modelfrom configtools/vision_tools.py:_handle_vision_analyzeand_handle_video_analyzenow readauxiliary.vision.model/auxiliary.video.modelfrom configBefore vs After
auxiliary.vision.modelset in config, no env varAUXILIARY_VISION_MODELenv var setTests
py_compilepasses on both modified filesFixes #24842