fix: route background memory review by destination - #24846
Open
nicha16 wants to merge 1 commit into
Open
Conversation
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused memory-routing change. The underlying issue remains on current main: agent/background_review.py:160-168 and agent/background_review.py:276-281 still use broad admission wording, while tools/memory_tool.py:1076-1086 already defines the narrower USER.md/MEMORY.md/skip contract.
Problems
- The prompt definitions were moved from
run_agent.pytoagent/background_review.pybyd35ee7bc;run_agent.py:1576-1582now only re-exports them. The current PR is therefore dirty against main and its implementation hunk cannot be applied at the original location.
Suggested changes
- Transplant the prompt and test intent to
agent/background_review.py, keeping the routing language aligned withtools/memory_tool.py:1076-1086.
Automated hermes-sweeper review.
| @@ -3986,14 +3986,24 @@ def _cleanup_task_resources(self, task_id: str) -> None: | |||
| # ------------------------------------------------------------------ | |||
Contributor
There was a problem hiding this comment.
Current main moved these prompt definitions to agent/background_review.py in d35ee7bc; run_agent.py:1576-1582 now only re-exports them. Please salvage this hunk at the active source location so the routing change reaches the prompt used by the background-review thread.
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python -m pytest tests/run_agent/test_background_review.py tests/run_agent/test_review_prompt_class_first.py -q -o 'addopts='