Enable Topic in Feishu. - #24843
Closed
Readm wants to merge 2 commits into
Closed
Enable Topic in Feishu.#24843Readm wants to merge 2 commits into
Readm wants to merge 2 commits into
Conversation
…s via root_id/thread_id - Resolve thread_id from message.root_id or message.message_id instead of message.thread_id for proper topic threading - Route interim/stream/progress messages carrying thread_id metadata into the thread via message.reply() instead of message.create() - Fixes Feishu topic threading where messages could land in the main chat instead of inside the topic
…ssage routing - test_inbound_message_uses_root_id_as_thread_id - test_inbound_message_falls_back_to_message_id_when_no_root_id - test_inbound_message_no_thread_id_when_neither_root_nor_message_id - test_send_raw_message_replies_into_thread_when_metadata_has_thread_id - test_send_raw_message_creates_when_no_reply_to_and_no_thread_id_in_metadata
alt-glitch
added
type/feature
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Topic in Feishu. via root_id/thread_id
What does this PR do?
Enable Topic in Feishu, with this, whenever you chat with the hermes Feishu bot, it create a new Topic in Feishu, corresponding to Session in Hermes. Otherwise, you have only one session to hermes via Feishu (or creat a group and @ him each message)
I like it very much, I'm not sure everybody likes it? should we add a config to it?
Type of Change
Changes Made
gateway/platforms/feishu.py
How to Test
Only manully, maybe we can add test that use correct thead_id?
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass