fix(dashboard): bundle backdrop filler image via Vite import (#24355) by Tranquil-Flow · Pull Request #24713 · NousResearch/hermes-agent

Tranquil-Flow · 2026-05-13T01:46:12Z

What does this PR do?

When this PR was first opened, web/src/components/Backdrop.tsx still imported the filler image via the fragile /ds-assets/filler-bg0.* public path that depended on the sync-assets prebuild hook firing. Direct vite build, partial prebuild failures, or _build_web_ui's stale-dist fallback (#23817) would silently 404 the asset and the default backdrop would disappear. The PR switched the import to @nous-research/ui/assets/filler-bg0.webp so Vite bundles a content-hashed copy into web_dist/assets/.

That Backdrop.tsx change has since landed on main independently (along with removal of the redundant sync-assets / predev / prebuild scripts), so the original code change is no longer needed.

This PR now carries the two remaining pieces around that landed change:

Regression contract test (tests/tools/test_backdrop_filler_bundling.py) — asserts Backdrop.tsx does NOT reference the fragile public path and DOES import via the design-system package's ./assets/* export. The import-pattern assertion uses a regex that tolerates either quote style and either .webp / .jpg extension so future ds-asset bumps or reformats don't false-positive the contract.
@nous-research/ui bump 0.14.0 → 0.15.0 per @austinpickett's request — the breaking changes that surfaced the original regression originate in the 0.15.0 release. Verified that 0.15.0 still ships dist/assets/filler-bg0.webp + dist/hooks/use-gpu-tier + every dist/ui/components/{button,list-item,selection-switcher,spinner,badge,select,tabs,command-block} import used in web/src/. npm run build passes clean.

Related Issue

Addresses #24355 (original code change already on main; this PR adds the regression test + the upstream-requested ui bump)

Type of Change

🐛 Bug fix (non-breaking change that fixes an issue)
✨ New feature (non-breaking change that adds functionality)
🔒 Security fix
📝 Documentation update
✅ Tests (adding or improving test coverage)
♻️ Refactor (no behavior change)
🎯 New skill (bundled or hub)

Changes Made

tests/tools/test_backdrop_filler_bundling.py (new, 63 LOC, 2 tests) — contract guard against re-introducing the /ds-assets/ public-path dependency in Backdrop.tsx.
web/package.json — bump @nous-research/ui from 0.14.0 to 0.15.0.
web/package-lock.json — regenerated against 0.15.0.

How to Test

pytest tests/tools/test_backdrop_filler_bundling.py -q → 2 passed.
cd web && npm install && npm run build → vite build passes clean; web_dist/assets/filler-bg0-<hash>.webp emitted.
Reverting either Backdrop.tsx import on a local branch should fail one of the two contract assertions.

Checklist

Code

I've read the Contributing Guide
My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
I searched for existing PRs to make sure this isn't a duplicate
My PR contains only changes related to this fix/feature (no unrelated commits)
I've run pytest tests/ -q and all tests pass
I've added tests for my changes (required for bug fixes, strongly encouraged for features)
I've tested on my platform: macOS 15 (Darwin 24.6.0)

Documentation & Housekeeping

I've updated relevant documentation (README, docs/, docstrings) — or N/A
I've updated cli-config.yaml.example if I added/changed config keys — or N/A
I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

$ pytest tests/tools/test_backdrop_filler_bundling.py -q
..                                                                       [100%]
2 passed in 8.68s

$ cd web && npm run build
vite v7.3.2 building client environment for production...
✓ 2067 modules transformed.
../hermes_cli/web_dist/assets/filler-bg0-RwOqXSl_.webp    931.56 kB
../hermes_cli/web_dist/assets/index-DK2Uerqs.js         1,581.97 kB │ gzip: 460.21 kB
✓ built in 6.08s

austinpickett · 2026-05-18T14:50:22Z

+// Import directly so Vite bundles the asset; the prior `/ds-assets/...`
+// path 404s whenever the `npm run sync-assets` prebuild hook is bypassed
+// (issue #24355).
+import fillerBg from "@nous-research/ui/assets/filler-bg0.jpg";


fillerBg has moved to filler-bg0.webp

Fixed — import now references filler-bg0.webp (verified via npm pack: the @nous-research/ui@0.10.0 lockfile-pinned version ships .jpg, but 0.15.0 ships only .webp so any lockfile bump would have broken the old path). New head: 798ec38.

Copilot

Pull request overview

This PR fixes a dashboard regression where the default backdrop filler image could 404 when sync-assets didn’t populate web/public/ds-assets/ (e.g., direct vite build, partial prebuild failure, or stale-dist fallback). It switches the filler image to be bundled via a Vite-resolved module import so the asset is emitted into web_dist/assets/ with a content-hashed name.

Changes:

Update Backdrop to import the filler image via @nous-research/ui/assets/filler-bg0.jpg and use the bundled URL in <img src>.
Add a contract test ensuring Backdrop.tsx doesn’t reference the fragile /ds-assets/... path and does import via the design system package export.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
web/src/components/Backdrop.tsx	Replaces a fragile public-path image reference with a Vite-bundled asset import.
tests/tools/test_backdrop_filler_bundling.py	Adds a regression/contract test to prevent reintroducing the `/ds-assets/` dependency for the default backdrop filler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Tranquil-Flow · 2026-05-19T09:52:44Z

+    source = BACKDROP.read_text(encoding="utf-8")
+    assert '"@nous-research/ui/assets/filler-bg0.jpg"' in source, (
+        "Backdrop.tsx must import the filler image from "
+        "`@nous-research/ui/assets/filler-bg0.jpg` so Vite bundles it. "
+        "See #24355."
+    )


Loosened — the assertion is now a regex tolerating either quote style and either extension:

pattern = re.compile( r'''from\s+['"]@nous-research/ui/assets/filler-bg0\.(?:webp|jpg)['"]''' ) assert pattern.search(source), ...

Formatting changes (single vs double quotes, whitespace, multi-line import) no longer break the contract. Negative check on /ds-assets/ is unchanged. New head: 798ec38.

Tranquil-Flow · 2026-05-19T09:48:05Z

@austinpickett — fixed the filler-bg rename: import now references filler-bg0.webp (matching the moved asset).

Also addressed the Copilot inline note on test_backdrop_filler_bundling.py:55 — the contract assertion is now a regex that tolerates either quote style and either extension, so future formatting changes don't break it.

New head: 798ec38. Ready for another look.

austinpickett · 2026-05-19T10:34:06Z

It's important to bump the @nous-research/ui package first, 0.15.0. There's some breaking changes that were caused from that.

https://design.nousresearch.com

Tranquil-Flow · 2026-05-19T11:40:46Z

It's important to bump the @nous-research/ui package first, 0.15.0. There's some breaking changes that were caused from that.

https://design.nousresearch.com

Copy that, will integrate this.

austinpickett · 2026-05-19T11:55:21Z

@copilot resolve the merge conflicts in this pull request

Tranquil-Flow · 2026-05-19T13:41:18Z

@austinpickett — done, and the PR is now narrower than it was.

Turns out the Backdrop.tsx .webp import change itself has already landed on main independently (and the redundant sync-assets / predev / prebuild scripts were removed) — so the code change this PR was originally about is no longer needed.

Reformulated the PR around the two remaining pieces:

@nous-research/ui bump 0.14.0 → 0.15.0 (your ask). Verified 0.15.0 ships every component + hook + asset path that web/src/ imports; npm run build passes clean with the bumped version.
tests/tools/test_backdrop_filler_bundling.py — regression contract test (2 cases) that ensures Backdrop.tsx can't silently regress back to the /ds-assets/ public-path approach. Tolerant regex on the import pattern so it accepts either .webp / .jpg and either quote style.

New head: 81f70832. MERGEABLE. Diff is now +292 / −1975 (the deletions are the redundant 0.10.0 lockfile entries the rebase cleaned up against the 0.14.0-baseline main).

Happy to split the ui bump out as its own PR if you'd prefer the test landing separately.

austinpickett

Review: fix(dashboard): bundle backdrop filler image via Vite import

Contract test + @nous-research/ui version bump. The actual Vite import fix landed in a prior commit; this PR adds the regression guard.

(item 1) Contract test is well-designed — negative check (no /ds-assets/filler-bg0 literal) + positive check (import from @nous-research/ui/assets/). Regex tolerates quote style and extension changes. Thorough docstring.

(item 2) Version bump 0.14.0 → 0.15.0 is a minor bump that presumably adds the ./assets/* package export map entry Vite needs. Pinned version appropriate for internal design system.

(item 3) 4500+ line package-lock.json diff is mechanical.

Verdict: Approve ✅ — Clean regression guard.

Reviewed by Hermes Agent

…earch#24355)

alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels May 13, 2026

austinpickett requested a review from Copilot May 18, 2026 14:49

austinpickett requested changes May 18, 2026

View reviewed changes

Copilot AI reviewed May 18, 2026

View reviewed changes

Copilot started reviewing on behalf of austinpickett May 18, 2026 14:54 View session

Tranquil-Flow force-pushed the fix/24355-bundle-filler-bg-via-vite branch from 798ec38 to 81f7083 Compare May 19, 2026 13:40

Tranquil-Flow requested a review from a team May 19, 2026 13:40

austinpickett previously approved these changes May 20, 2026

View reviewed changes

Tranquil-Flow force-pushed the fix/24355-bundle-filler-bg-via-vite branch from 81f7083 to 09b386f Compare May 25, 2026 14:04

fix(dashboard): bundle backdrop filler image via Vite import (NousRes…

529bf17

…earch#24355)

Tranquil-Flow force-pushed the fix/24355-bundle-filler-bg-via-vite branch from 09b386f to 529bf17 Compare May 25, 2026 14:15

Tranquil-Flow dismissed austinpickett’s stale review via 529bf17 May 28, 2026 23:01

austinpickett closed this May 29, 2026

teknium1 mentioned this pull request Jun 11, 2026

[Bug]: Hermes logo missing when running dashboard in docker, actually after updating to the newest version the logo is gone. #24355

Closed

1 task

Navigation Menu

Uh oh!

fix(dashboard): bundle backdrop filler image via Vite import (#24355) - #24713

fix(dashboard): bundle backdrop filler image via Vite import (#24355)#24713
Tranquil-Flow wants to merge 1 commit into
NousResearch:mainfrom
Tranquil-Flow:fix/24355-bundle-filler-bg-via-vite

Tranquil-Flow commented May 13, 2026 •

edited

Loading

Uh oh!

austinpickett May 18, 2026

Uh oh!

Tranquil-Flow May 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Tranquil-Flow May 19, 2026

Uh oh!

Tranquil-Flow commented May 19, 2026

Uh oh!

austinpickett commented May 19, 2026

Uh oh!

Tranquil-Flow commented May 19, 2026

Uh oh!

austinpickett commented May 19, 2026

Uh oh!

Tranquil-Flow commented May 19, 2026

Uh oh!

austinpickett left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Tranquil-Flow commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Related Issue

Type of Change

Changes Made

How to Test

Checklist

Code

Documentation & Housekeeping

Screenshots / Logs

Uh oh!

austinpickett May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Tranquil-Flow May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Tranquil-Flow May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Tranquil-Flow commented May 19, 2026

Uh oh!

austinpickett commented May 19, 2026

Uh oh!

Tranquil-Flow commented May 19, 2026

Uh oh!

austinpickett commented May 19, 2026

Uh oh!

Tranquil-Flow commented May 19, 2026

Uh oh!

austinpickett left a comment

Choose a reason for hiding this comment

Review: fix(dashboard): bundle backdrop filler image via Vite import

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tranquil-Flow commented May 13, 2026 •

edited

Loading