Skip to content

fix(whatsapp-bridge): bump @whiskeysockets/baileys and resolve transitive protobufjs vulns - #24677

Closed
kairoxxai wants to merge 1 commit into
NousResearch:mainfrom
kairoxxai:soma/whatsapp-bridge-vuln-fix
Closed

fix(whatsapp-bridge): bump @whiskeysockets/baileys and resolve transitive protobufjs vulns#24677
kairoxxai wants to merge 1 commit into
NousResearch:mainfrom
kairoxxai:soma/whatsapp-bridge-vuln-fix

Conversation

@kairoxxai

Copy link
Copy Markdown

Summary

Closes 4 of 7 npm audit findings (3 high, 1 moderate) in scripts/whatsapp-bridge/:

  • Bump @whiskeysockets/baileys 7.0.0-rc.9 → 7.0.0-rc10
  • npm audit fix resolves transitive protobufjs / libsignal advisories where possible

Remaining vulnerabilities (not addressed here)

3 vulns remain (2 moderate, 1 critical), all in the same chain:

protobufjs 6.8.8 (vulnerable)
  └─ libsignal (pinned to protobufjs 6.8.8 in package.json)
       └─ @whiskeysockets/libsignal-node
            └─ @whiskeysockets/baileys (pinned)

The critical (GHSA-685m-2w69-288q — protobufjs DoS via unbounded recursion) is blocked by libsignal's hard pin to protobufjs@6.8.8. Resolving it requires either upstream baileys to ship a libsignal refresh, or npm overrides to force a newer protobufjs (which carries runtime risk — protobufjs 6.x → 7.x has minor API breaks libsignal may not tolerate).

Test plan

  • node --check bridge.js — syntax OK
  • All deps load via dynamic import (baileys, express, pino, qrcode-terminal, allowlist.js)
  • node allowlist.test.mjs — 4/4 tests pass
  • Real WhatsApp connection / message round-trip — not exercised in this PR

… vulns

Closes 4 of 7 npm audit findings (3 high, 1 moderate). Remaining 3
(2 moderate, 1 critical protobufjs DoS) blocked by libsignal hard
pinning protobufjs 6.8.8 inside @whiskeysockets/libsignal-node;
upstream baileys has not refreshed it. Revisit when baileys ships
7.0.0 final or apply npm overrides if exposure changes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@kairoxxai
kairoxxai requested a review from a team May 13, 2026 00:42
@alt-glitch alt-glitch added type/security Security vulnerability or hardening P3 Low — cosmetic, nice to have platform/whatsapp WhatsApp Business adapter javascript labels May 13, 2026
@austinpickett
austinpickett requested a review from Copilot May 19, 2026 12:13

@austinpickett austinpickett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use .github/PULL_REQUEST_TEMPLATE.md and fix merge conflicts.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps @whiskeysockets/baileys from 7.0.0-rc.9 to ^7.0.0-rc10 in the WhatsApp bridge scripts and refreshes the lockfile to pull in patched transitive dependencies (protobufjs, path-to-regexp, music-metadata, etc.), resolving 4 of 7 npm audit findings. Remaining 3 vulnerabilities are blocked by libsignal's pin to protobufjs@6.8.8.

Changes:

  • Bump @whiskeysockets/baileys dependency range to ^7.0.0-rc10.
  • Regenerate package-lock.json to pick up patched transitive deps and drop optional @img/sharp-* / @emnapi/runtime entries no longer required.
  • Pull in new transitive dep whatsapp-rust-bridge@0.5.3.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/whatsapp-bridge/package.json Updates baileys version range and reorders deps alphabetically.
scripts/whatsapp-bridge/package-lock.json Regenerated lockfile reflecting the baileys bump and patched transitive deps.
Files not reviewed (1)
  • scripts/whatsapp-bridge/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the dependency-audit work. This is now superseded by a stronger implementation already on main.

Automated hermes-sweeper review.

@teknium1 teknium1 closed this Jul 13, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have platform/whatsapp WhatsApp Business adapter sweeper:implemented-on-main Sweeper: behavior already present on current main type/security Security vulnerability or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants