Conversation
Collaborator
|
Thanks for identifying the CLI/slash-command drift. The underlying bug is still present on current main, but this needs a small salvage onto the extracted handler. Problems
Suggested changes
Automated hermes-sweeper review. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the interactive
/cronslash command so it matches the real cron CLI surface more closely.It now forwards
--script,--workdir,--no-agent, and--agentcorrectly, and adds/cron statusand/cron ticksupport. This prevents script-backed cron jobs from losing important options when created or edited from chat.Related Issue
--
Type of Change
Changes Made
/cronslash parsing incli.pystatusandtickto cron subcommand metadataHow to Test
uv run pytest tests/cli/test_cli_cron_command.py tests/hermes_cli/test_commands.pyuv run ruff check cli.py hermes_cli/commands.py tests/cli/test_cli_cron_command.py tests/hermes_cli/test_commands.py