fix: add missing get_registry() function for CLI /stop command - #2458
Closed
haiyuzhong1980 wants to merge 1 commit into
Closed
haiyuzhong1980 wants to merge 1 commit into
haiyuzhong1980 wants to merge 1 commit into
Conversation
The cli.py imports get_registry from tools.process_registry but the function was never defined, causing ImportError when running /stop: Error: cannot import name 'get_registry' from 'tools.process_registry' This commit adds the missing get_registry() function that returns the module-level process_registry singleton.
teknium1
added a commit
that referenced
this pull request
Mar 22, 2026
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in #2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR #2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in #2424 by 42-evey)
Collaborator
|
Fixed in PR #2463 — used the actual process_registry singleton instead of the non-existent get_registry(). Thanks for reporting! |
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in NousResearch#2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR NousResearch#2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in NousResearch#2424 by 42-evey)
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in NousResearch#2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR NousResearch#2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in NousResearch#2424 by 42-evey)
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in NousResearch#2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR NousResearch#2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in NousResearch#2424 by 42-evey)
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in NousResearch#2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR NousResearch#2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in NousResearch#2424 by 42-evey)
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in NousResearch#2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR NousResearch#2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in NousResearch#2424 by 42-evey)
melon-xf
added a commit
to melon-xf/hermes-agent
that referenced
this pull request
Sep 3, 2026
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in NousResearch#2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR NousResearch#2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in NousResearch#2424 by 42-evey)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CLI imports
get_registryfromtools.process_registrybut the function was never defined:This causes the
/stopcommand to fail.Solution
Added the missing
get_registry()function that returns the module-levelprocess_registrysingleton.Testing
python -m py_compile tools/process_registry.pyFiles Changed
tools/process_registry.py: Addedget_registry()function (9 lines)