Skip to content

fix(telegram): reset sticky fallback IP on connect failure #24511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
falconexe wants to merge 1 commit into from
Closed

fix(telegram): reset sticky fallback IP on connect failure #24511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions gateway/platforms/telegram_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ async def handle_async_request(self, request: httpx.Request) -> httpx.Response:

sticky_ip = self._sticky_ip
attempt_order: list[Optional[str]] = [sticky_ip] if sticky_ip else [None]
if sticky_ip:
attempt_order.append(None) # retry primary DNS after sticky failure
for ip in self._fallback_ips:
if ip != sticky_ip:
attempt_order.append(ip)
Expand All @@ -99,6 +101,14 @@ async def handle_async_request(self, request: httpx.Request) -> httpx.Response:
last_error = exc
if not _is_retryable_connect_error(exc):
raise
if ip is not None and ip == self._sticky_ip:
async with self._sticky_lock:
if self._sticky_ip == ip:
self._sticky_ip = None
logger.warning(
"[Telegram] Sticky fallback IP %s failed; resetting to primary DNS path",
ip,
)
if ip is None:
logger.warning(
"[Telegram] Primary api.telegram.org connection failed (%s); trying fallback IPs %s",
Expand Down