fix(gateway): use metadata thread_id for Mattermost root_id - #24420
Closed
steveafrost wants to merge 1 commit into
Closed
fix(gateway): use metadata thread_id for Mattermost root_id#24420steveafrost wants to merge 1 commit into
steveafrost wants to merge 1 commit into
Conversation
Mattermost requires root_id to be the thread root post ID, not the specific message being replied to. The reply_to parameter contains the message_id which is incorrect for root_id. This fix uses metadata["thread_id"] (the actual root post ID) when available, falling back to reply_to for backward compatibility. Affected methods: - send_message - send_image_url - send_image_file - send_document - send_voice - send_video
Collaborator
Author
|
Closing as duplicate of #20874 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mattermost replies were not threading correctly. The
root_idfield must contain the thread root post ID, not the specific message being replied to.Root Cause
The adapter was passing
reply_to(the message_id) asroot_id, causing each reply to start a new thread instead of continuing the existing one.Solution
Use
metadata["thread_id"](the actual root post ID) when available, falling back toreply_tofor backward compatibility.Changes
send_message(): Useseffective_reply_to = metadata.get("thread_id") or reply_tosend_image_url(): Same patternsend_image_file(): Same patternsend_document(): Same patternsend_voice(): Same patternsend_video(): Same patternTesting