feat(agent): add retry warning suppression config - #24387
Closed
BlackishGreen33 wants to merge 2 commits into
Closed
feat(agent): add retry warning suppression config#24387BlackishGreen33 wants to merge 2 commits into
BlackishGreen33 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new agent.suppress_retry_warnings configuration option to reduce user-visible retry noise during transient API failures while keeping logging and final failure behavior intact.
Changes:
- Introduces
agent.suppress_retry_warnings(defaultfalse) in the default config. - Parses and stores the suppression flag on
AIAgentand uses it to gate retry-related output. - Adds tests covering default behavior, config overrides, and
_emit_retry_statussuppression.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
run_agent.py |
Adds suppression flag parsing + _emit_retry_status, and gates retry warning/status emissions. |
hermes_cli/config.py |
Adds default config key and bumps _config_version. |
tests/run_agent/test_api_max_retries_config.py |
Extends existing config-surface tests to cover suppress_retry_warnings and retry status emission. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2045
to
+2051
| _raw_suppress_retry_warnings = _agent_section.get( | ||
| "suppress_retry_warnings", False | ||
| ) | ||
| self._suppress_retry_warnings = ( | ||
| str(_raw_suppress_retry_warnings).strip().lower() | ||
| in {"1", "true", "yes", "on"} | ||
| ) |
Comment on lines
+2853
to
+2854
| """Emit retry status unless the user opted out of retry noise.""" | ||
| if getattr(self, "_suppress_retry_warnings", False): |
Comment on lines
+469
to
+470
| # Suppress non-critical terminal noise for transient API retry attempts. | ||
| # Logs and final failures are still emitted. |
| "backup_keep": 5, | ||
| }, | ||
|
|
||
| # Config schema version - bump this when adding new required fields |
alt-glitch
added
type/feature
…s-retry-warnings # Conflicts: # run_agent.py
3 tasks
Contributor
|
Automated hermes-sweeper review: this has been implemented on current main by the retry/fallback status buffering work. Main does not add the exact Evidence:
Thanks for the focused PR and for linking it to #24083; that issue’s concrete retry-noise report lines up with the behavior now present on main. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24083
Summary
agent.suppress_retry_warnings, defaulting tofalseso existing behavior is unchanged.Testing
python -m py_compile run_agent.py hermes_cli/config.pypython -m pytest tests/run_agent/test_api_max_retries_config.py -qpython -m pytest tests/cli/test_fast_command.py -qpython -m pytest tests/ -qwas attempted; it failed on the current local environment with missing optional packages (acp,fastapi,numpy) and existing gateway/platform environment failures. The focused tests above passed.