fix(gateway): resolve adapter before _deliver_media_from_response - #2432
Closed
MacroAnarchy wants to merge 1 commit into
Closed
fix(gateway): resolve adapter before _deliver_media_from_response#2432MacroAnarchy wants to merge 1 commit into
MacroAnarchy wants to merge 1 commit into
Conversation
The 'adapter' variable in _handle_message_with_agent is only assigned
conditionally (first-message home-channel hint or Discord voice context),
so it is unbound on the normal streaming path when already_sent is True.
This causes an UnboundLocalError on every streamed response:
UnboundLocalError: cannot access local variable 'adapter'
where it is not associated with a value
Resolve the adapter from self.adapters just before the call and guard
against None so media delivery degrades gracefully instead of crashing
the entire message handler.
Contributor
|
Duplicate of #2424 |
Contributor
Author
|
Didn't see #2424 — same fix. Closing as duplicate. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When streaming is enabled (
already_sent=True),_handle_message_with_agentcalls_deliver_media_from_response(response, event, adapter)at line 2321 — butadapteris only assigned conditionally earlier in the method (first-message home-channel hint or Discord voice context).On the normal Telegram/Slack/etc streaming path,
adapteris never bound, causing:This crashes every streamed response that contains media files.
Fix
Resolve
adapterfromself.adapters.get(source.platform)immediately before the call, with aNoneguard so media delivery degrades gracefully instead of crashing the entire message handler.Testing
Verified on a live Telegram gateway — streamed responses now complete without errors.