Skip to content

fix(feishu): keep topic replies out of main chat - #24301

Closed
asdlem wants to merge 1 commit into
NousResearch:mainfrom
asdlem:fix/feishu-topic-routing
Closed

fix(feishu): keep topic replies out of main chat#24301
asdlem wants to merge 1 commit into
NousResearch:mainfrom
asdlem:fix/feishu-topic-routing

Conversation

@asdlem

@asdlem asdlem commented May 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • canonicalize Feishu topic session keys on root message IDs so one topic does not split between om_ and omt_ variants
  • carry Feishu reply anchors through the shared thread metadata used by normal gateway sends
  • make Feishu topic sends use message.reply with reply_in_thread=true even when callers only pass thread_id, avoiding accidental top-level DM posts

Tests

  • /Users/hywl/.hermes/hermes-agent/venv/bin/python -m pytest -o addopts='' tests/gateway/test_feishu.py tests/gateway/test_telegram_topic_mode.py tests/gateway/test_reply_to_injection.py tests/gateway/test_session_race_guard.py

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery platform/feishu Feishu / Lark adapter labels May 12, 2026
@asdlem
asdlem force-pushed the fix/feishu-topic-routing branch from 7313d49 to a237928 Compare May 12, 2026 10:40
@asdlem

asdlem commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

main now has root_id→thread_id unification (om_/omt_ canonicalization) — this PR is superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants