fix(gateway): skip home-channel onboarding when configured in config.yaml - #24282
Open
arthurnunesc wants to merge 1 commit into
Open
fix(gateway): skip home-channel onboarding when configured in config.yaml#24282arthurnunesc wants to merge 1 commit into
arthurnunesc wants to merge 1 commit into
Conversation
…yaml
The daily onboarding notice ('No home channel is set...') only checked
os.getenv() for the home channel env var. This meant users who had the
home channel set via config.yaml (platforms.telegram.home_channel) but
lacked the env variable — e.g. after a gateway restart where dotenv
wasn't reloaded — would get spuriously prompted every day.
Now the check also falls back to self.config.get_home_channel() so that
a home channel configured in config.yaml is respected even when the env
var is missing.
Fixes daily 'No home channel is set' spam for users with static config.
alt-glitch
added
type/bug
teknium1
added
sweeper:risk-message-delivery
Contributor
|
Thanks for the focused regression fix. Current main still has the env-only condition at Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily onboarding notice ('No home channel is set...') only checked `os.getenv()` for the home channel env var. This meant users who had the home channel set via `config.yaml` (`platforms.telegram.home_channel`) but lacked the env variable — e.g. after a gateway restart where dotenv wasn't reloaded — would get spuriously prompted every day.
Now the check also falls back to `self.config.get_home_channel()` so that a home channel configured in `config.yaml` is respected even when the env var is missing.
Changes:
Fixes daily 'No home channel is set' spam for users with static config.