Skip to content

fix(gateway): skip fake finalize hook on first /new - #24276

Closed
rylena wants to merge 1 commit into
NousResearch:mainfrom
rylena:fix/issue-12176-gateway-new-finalize-guard
Closed

fix(gateway): skip fake finalize hook on first /new#24276
rylena wants to merge 1 commit into
NousResearch:mainfrom
rylena:fix/issue-12176-gateway-new-finalize-guard

Conversation

@rylena

@rylena rylena commented May 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • skip on_session_finalize when /new runs before any prior session exists
  • keep on_session_reset firing for the newly created session
  • add regression coverage for the first-session /new path

Verification

  • scripts/run_tests.sh tests/gateway/test_session_boundary_hooks.py -q
  • independent delegated code review: passed

Notes

Closes #12176

@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels May 12, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #23255 (and earlier #12184). All fix the same issue #12176 — skipping on_session_finalize when no prior session exists on /new.

@rylena

rylena commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Closing this as a duplicate of #23255 / #12184 for the same #12176 finalize-guard fix. I am not refreshing or pushing this branch further so effort stays concentrated on the earlier open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/new emits on_session_finalize(session_id=None) when no prior session exists

2 participants