chore: fix ruff E741 — rename ambiguous variable l to descriptive names - #24233
Closed
ryptotalent wants to merge 1 commit into
Closed
chore: fix ruff E741 — rename ambiguous variable l to descriptive names#24233ryptotalent wants to merge 1 commit into
ryptotalent wants to merge 1 commit into
Conversation
…ames Rename 'l' (easily confused with digit '1') to descriptive names across 5 files: link, length, line. All instances verified against surrounding context. Zero logic changes. Fixes remaining E741 warnings from ruff check (6 errors across gateway/platforms/feishu_comment.py, gateway/platforms/signal.py, tools/fuzzy_match.py, tools/patch_parser.py, tools/tts_tool.py). Follows same pattern as merged ruff cleanup PRs NousResearch#23940, NousResearch#23937, NousResearch#23926.
alt-glitch
added
type/refactor
Contributor
|
Closing — stale PR from May. Ruff E741 fixes are low-priority lint changes. If these variables are still ambiguous, a fresh PR can be created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the ambiguous variable name
l(easily confused with the digit1) to descriptive, context-appropriate names across 5 files. This fixes the remaining E741 warnings flagged by ruff.Changes
gateway/platforms/feishu_comment.py:l→linkin wiki-links list comprehensiongateway/platforms/signal.py:l→lengthin style-adjustment looptools/fuzzy_match.py:l→linein closest-lines candidate filtertools/patch_parser.py:l→linein hunk search/replace line extraction (2 instances)tools/tts_tool.py:l→linein NeuTTS stderr filterTest Plan
ruff check --select=E741passes (0 errors, was 6)py_compilepasses for all 5 modified filesFollows the same pattern as previously merged ruff cleanup PRs (#23940, #23937, #23926).