fix: harden doctor gemini and wal checks - #24033
Open
Inchesdeep wants to merge 1 commit into
Open
Conversation
- use x-goog-api-key for Gemini native /models probing - use wal_checkpoint(TRUNCATE) for doctor --fix - report incomplete WAL cleanup honestly - add regression coverage for Gemini probe and WAL checkpoint behavior
alt-glitch
added
type/bug
Collaborator
4 tasks
3 tasks
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the WAL diagnosis and regression coverage.
Problems
- The Gemini hunk is already superseded: current main commit
364a1dd290245093f76837c6074bb7d4fdc798c6implements the probe athermes_cli/doctor.py:1928-1937, using the resolvedgenerativelanguage.googleapis.comhost. The proposed provider-name-only branch athermes_cli/doctor.py:1371is less precise than that current behavior. - The WAL premise remains live: current
hermes_cli/doctor.py:1332-1339still runswal_checkpoint(PASSIVE)and reports success unconditionally.
Suggested changes
- Salvage the WAL
TRUNCATEand incomplete-cleanup reporting against the current doctor implementation. - Adapt the Gemini regression test to the current URL-host-based behavior; do not restore the stale provider-name branch.
Automated hermes-sweeper review.
| @@ -1359,10 +1370,14 @@ def _probe_apikey_provider(pname, env_vars, default_url, base_env, | |||
| if base_url_host_matches(base, "api.kimi.com") and base.rstrip("/").endswith("/coding"): | |||
| base = base.rstrip("/") + "/v1" | |||
Contributor
There was a problem hiding this comment.
Please do not key this solely on pname. Current main already implements the Gemini fix by matching the resolved URL host (hermes_cli/doctor.py:1934-1936), which is more precise; retain that approach when salvaging the WAL portion.
teknium1
added
sweeper:risk-compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-goog-api-keyinstead of generic Bearer authhermes doctor --fixWAL cleanup fromwal_checkpoint(PASSIVE)towal_checkpoint(TRUNCATE)Why
hermes doctorwas producing a false negative for valid Gemini API keys because the native Gemini/v1beta/modelsendpoint does not use Bearer auth. Separately, doctor could claim it fixed a large SQLite WAL file even when the file size did not materially shrink.Evidence
https://generativelanguage.googleapis.com/v1beta/modelsreturned HTTP 200 with the configured key✓ geminiscripts/run_tests.sh tests/hermes_cli/test_doctor.py -qVerification
hermes doctorscripts/run_tests.sh tests/hermes_cli/test_doctor.py -qgit diff --checkNotes
This PR comes from a fork because direct push permission to
NousResearch/hermes-agentwas not available from this machine.