fix(kanban): fingerprint crash errors to prevent fleet-wide retry exhaustion - #24023
Closed
bradhallett wants to merge 1 commit into
Closed
fix(kanban): fingerprint crash errors to prevent fleet-wide retry exhaustion#24023bradhallett wants to merge 1 commit into
bradhallett wants to merge 1 commit into
Conversation
…austion When a systemic failure (provider outage, auth expiry, OOM) crashes multiple workers simultaneously, detect_crashed_workers increments each task failure counter independently. The circuit breaker only trips after N × failure_limit retries across the fleet. Fingerprint crash errors by normalizing host-specific details (PIDs, timestamps). When 3+ tasks crash with the same fingerprint in a single detection cycle, immediately trip the circuit breaker (failure_limit=1) instead of waiting for repeated failures. Isolated crashes (unique fingerprints) retain their normal retry budget. Protocol violations continue to trip immediately. Includes regression tests for systemic and isolated crash paths.
alt-glitch
added
type/bug
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a systemic failure (provider outage, auth expiry, OOM) crashes multiple workers simultaneously,
detect_crashed_workersincrements each task's failure counter independently. The circuit breaker only trips after N × failure_limit retries across the entire fleet. This is fleet-wide retry exhaustion.Related Issue
No existing issue — discovered during operational review.
Type of Change
Changes Made
hermes_cli/kanban_db.py— Added_error_fingerprint()helper that normalizes crash errors (strips PIDs, timestamps). When 3+ tasks crash with the same fingerprint in a single detection cycle, the circuit breaker trips immediately (failure_limit=1) instead of waiting for repeated failures.tests/hermes_cli/test_kanban_db.py— Added two regression tests:test_detect_crashed_workers_systemic_failure_fast_block— 4 tasks with same error → all auto-blockedtest_detect_crashed_workers_isolated_failure_normal_retry— 2 tasks (below threshold) → normal retry budgetHow to Test
python -m pytest tests/hermes_cli/test_kanban_db.py -q -k "crash or systemic or isolated"Checklist