fix(kanban): reset failure counters on unblock_task - #24022
Closed
bradhallett wants to merge 1 commit into
Closed
Conversation
When a task is manually unblocked (blocked → ready/todo), the consecutive_failures counter and last_failure_error were left intact. The next failure would immediately re-trip the circuit breaker because the counter was still at or above the failure limit. Reset both fields on unblock so the task gets a fresh retry budget. Includes a regression test that verifies counters are zeroed.
alt-glitch
added
type/bug
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where
unblock_task()resets task status but leavesconsecutive_failuresandlast_failure_errorintact. The next failure immediately re-trips the circuit breaker because the counter is still at max.Related Issue
No existing issue — discovered during operational review of fleet-wide kanban dispatch failures.
Type of Change
Changes Made
hermes_cli/kanban_db.py— Addedconsecutive_failures = 0, last_failure_error = NULLto the UPDATE inunblock_task()tests/hermes_cli/test_kanban_db.py— Addedtest_unblock_resets_failure_countersregression testHow to Test
consecutive_failures = 5via raw SQLunblock_task()— verify counters are zeroedpython -m pytest tests/hermes_cli/test_kanban_db.py -q -k unblockChecklist