fix(cli): make kanban specify max_tokens configurable - #23988
Closed
argabor wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make Kanban Specify use a configurable token budget instead of a hardcoded 1500.
Changes
Why
When using reasoning/thinking models behind an OpenAI-compatible backend, 1500 tokens may be too low for Specify. Reasoning-capable Hermes-family models and similar backends can spend a large part of the completion budget on internal reasoning before producing the final assistant content.
In my reproduction with LM Studio:
Raising the available token budget resolved the failure in my local deployment, so making this value configurable seemed like the smallest useful upstream fix.
Default behavior
This change increases the default Specify completion budget from 1500 to 6000.
HERMES_KANBAN_SPECIFY_MAX_TOKENS can be used to override the value, but anything below 1500 is clamped to 1500.
Related
Testing
Tested manually with:
How to test:
Before
Specify could fail after the model exhausted the completion budget in reasoning and returned empty assistant content.
After
manual testing only; pytest not run