Conversation
added 3 commits
May 12, 2026 00:09
… spam When tirith is not installed on Windows but 'tirith' appears in PATH (e.g. from MSYS/Git Bash), shutil.which() returns a MSYS-style path (/mingw64/bin/tirith) that exists on disk but cannot be executed by Windows subprocess. The OSError was raised on every command without caching the failure, causing the same WARNING to fire 20+ times per session. Fix: mark _resolved_path = _INSTALL_FAILED in the OSError handler so subsequent check_command_security() calls short-circuit to 'path unavailable' (one WARNING) instead of retrying the same broken path. Closes NousResearch#23845
When Nous auth is not configured (no nous/login and no NOUS_API_KEY/NOUS_RUNTIME_API_KEY env vars), _try_nous() silently returned (None, None). The caller had no indication that this was an auth issue vs a general provider failure. Add a logger.warning() so operators can see in agent.log why the Nous provider is unavailable and how to fix it (run 'hermes auth nous' or set the env vars). This addresses the misleading-error-message aspect of NousResearch#23876: when the goal judge uses Nous and auth is missing, the warning now clearly indicates auth is the root cause rather than the model being faulty.
alt-glitch
added
type/bug
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23725