Skip to content

fix(tirith): cache OSError spawn failure to suppress repeated WARNING spam #23880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ms-alan wants to merge 1 commit into from
Closed

fix(tirith): cache OSError spawn failure to suppress repeated WARNING spam #23880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tools/tirith_security.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,14 @@ def check_command_security(command: str) -> dict:
timeout=timeout,
)
except OSError as exc:
# Covers FileNotFoundError, PermissionError, exec format error
# Covers FileNotFoundError, PermissionError, exec format error.
# On Windows with MSYS/Git Bash in PATH, shutil.which("tirith") may
# return a MSYS-style path (/mingw64/bin/tirith) that exists on disk
# but cannot be executed by Windows subprocess. Cache this failure
# so we don't retry and re-log on every subsequent command.
global _resolved_path, _install_failure_reason
_resolved_path = _INSTALL_FAILED
_install_failure_reason = "spawn_failed"
logger.warning("tirith spawn failed: %s", exc)
if fail_open:
return {"action": "allow", "findings": [], "summary": f"tirith unavailable: {exc}"}
Expand Down
Loading