fix(kanban): harden runtime recovery and worker startup - #23827
Closed
qWaitCrypto wants to merge 1 commit into
Closed
qWaitCrypto wants to merge 1 commit into
qWaitCrypto wants to merge 1 commit into
Conversation
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a focused Kanban resubmission against current
main.After the earlier Kanban hardening work in #23334,
mainhas since absorbedmany related Kanban PRs, including the create-time rejection path for toolset
names in
task.skillsand other dispatcher/runtime fixes. That made the olderstacked PR both partially superseded and broader than it needs to be now.
This PR intentionally narrows the scope and resubmits only the parts that still
add distinct value on top of current
main:In other words, this is the reduced follow-up to #23334 after recent Kanban
changes landed separately on
main.Related Issue
Related to #22925, #22926, #22927.
Follow-up to #23334.
This PR is a narrowed resubmission after recent Kanban merges on
mainsuperseded part of the earlier stack.
Type of Change
Changes Made
invalid_task_skillsassignee_profile_not_foundstale_running_claimhermes kanban edit <task> --clear-skillshermes kanban edit <task> --reset-failureshermes kanban edit <task> --clear-claimreadytasks whose persistedtask.skillsalreadycontain toolset names, while leaving the task
readyfor operator recoveryrunningcurrent_run_idstill matches the worker's expected runclaim_lockstill belongs to that workerrather than silently disabling the ownership check
skip behavior, and worker startup ownership checks
How to Test
pytest -q tests/hermes_cli/test_kanban_diagnostics.pypytest -q tests/hermes_cli/test_kanban_db.pypytest -q tests/hermes_cli/test_kanban_core_functionality.py tests/tools/test_kanban_tools.py tests/run_agent/test_kanban_worker_startup_guard.pyLocal targeted results:
tests/hermes_cli/test_kanban_diagnostics.py:31 passedtests/hermes_cli/test_kanban_db.py:82 passedtests/hermes_cli/test_kanban_core_functionality.py tests/tools/test_kanban_tools.py tests/run_agent/test_kanban_worker_startup_guard.py:215 passedChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs