Skip to content

fix(gateway): validate user authorization before auto-resume #23800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ygd58 wants to merge 1 commit into from
Closed

fix(gateway): validate user authorization before auto-resume #23800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions gateway/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3174,6 +3174,19 @@ def _schedule_resume_pending_sessions(self) -> int:
)
continue

# Validate that the session owner is still authorized before
# auto-resuming. Auth config may have changed between restarts
# (e.g. TELEGRAM_ALLOWED_USERS updated) — skip sessions whose
# owner is no longer in the allowlist (issue #23778).
_user_id = str(getattr(source, "user_id", "") or "")
if _user_id and hasattr(adapter, "_is_callback_user_authorized"):
if not adapter._is_callback_user_authorized(_user_id):
logger.warning(
"Skipping auto-resume for %s: user %s not authorized",
entry.session_key, _user_id,
)
continue

# Empty-text internal event — the _is_resume_pending branch in
# _handle_message_with_agent prepends the proper reason-aware
# system note before the turn runs.
Expand Down
Loading