fix(update): warn when gateway is running before hermes update - #23793
Closed
ygd58 wants to merge 1 commit into
Closed
fix(update): warn when gateway is running before hermes update#23793ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
Updating in-place while the gateway holds open connections (e.g. Telegram polling) can leave the bot token in a stale state and break messaging platforms after the update (issue NousResearch#23783). Add a pre-update check: if gateway PIDs are found, warn the user and prompt to confirm before proceeding. Recommended flow is: hermes gateway stop → hermes update → hermes gateway start Fixes NousResearch#23783 (partial - prevents the condition; does not recover already-broken Telegram polling state)
1 task
Contributor
|
This looks implemented on current main via the newer update/restart and Telegram conflict-recovery path. Automated hermes-sweeper review evidence:
The exact UX from this PR — warning before update and asking the user to manually stop/start — is not the path main chose, but the underlying bug this PR was trying to avoid is covered by the current automatic restart/conflict-recovery behavior. |
This was referenced Aug 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running hermes update while the gateway is active can leave Telegram polling in a broken state. Old process holds the bot token, new binary cannot re-bind it.
Fix
Add a pre-update gateway check: if running PIDs are found, warn the user and prompt to confirm. Recommended flow: hermes gateway stop → hermes update → hermes gateway start.
Fixes #23783 (partial)