fix(compression): pass custom providers to feasibility check - #23788
Closed
LeonSGP43 wants to merge 1 commit into
Closed
fix(compression): pass custom providers to feasibility check#23788LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
Collaborator
Contributor
|
This appears to be implemented on current Evidence:
Thanks for the PR. The duplicate note in the discussion was accurate; the requested custom-provider forwarding path is now present on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Passes
custom_providersthrough_check_compression_model_feasibility()so auxiliary compression models inherit per-modelcontext_lengthoverrides the same way the main model path already does. This avoids false 256K startup warnings when the compression model resolves through a custom provider entry with a larger configured context window.Related Issue
Fixes #23779
Type of Change
Changes Made
custom_providersintoget_model_context_length()insiderun_agent.py::_check_compression_model_feasibility()How to Test
uv run --frozen pytest -q -o addopts='' tests/run_agent/test_compression_feasibility.pyuv run --frozen ruff check run_agent.py tests/run_agent/test_compression_feasibility.pytest_feasibility_check_passes_custom_providersasserts the auxiliary feasibility lookup receives the configuredcustom_providerslistChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
17 passed in 1.01sfromtests/run_agent/test_compression_feasibility.pyAll checks passed!fromruff check run_agent.py tests/run_agent/test_compression_feasibility.py