feat(skills): implement profile-scoped skills directory isolation - #23754
Closed
akshan502 wants to merge 2 commits into
Closed
feat(skills): implement profile-scoped skills directory isolation#23754akshan502 wants to merge 2 commits into
akshan502 wants to merge 2 commits into
Conversation
This PR adds support for profile-specific skills directories, allowing multi-agent setups to have isolated toolsets. Changes: 1. Introduced _get_profile_skills_dir() to detect active profile via ~/.hermes/active_profile and return the corresponding skills path. 2. Modified scan_skill_commands() and _find_all_skills() to prioritize loading skills from the profile directory before falling back to the global skills directory. This solves the 'cognitive bloat' issue where all agents (main, architect, pm, etc.) load the same massive list of skills regardless of their role.
…icated file Removed the dependency on ~/.hermes/active_profile file. Now reads the active profile name directly from ~/.hermes/config.yaml under the 'active_profile' key. This centralizes configuration and removes the split-state design flaw.
alt-glitch
added
type/feature
Contributor
|
Thanks for the profile-isolation contribution. This is an automated hermes-sweeper review; current
The timeline-linked discussion around #43796 identified the long-lived-runtime concern; the merged implementation covers that broader path without relying on a separate |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces Profile-Scoped Skills Isolation, allowing multi-agent setups (e.g.,
main,architect,pm) to load distinct toolsets based on their role.It solves the "cognitive bloat" issue where all agents load the same massive list of skills regardless of their function, causing role confusion and prompt inflation.
Implementation
active_profilein~/.hermes/config.yaml(adhering to Single Source of Truth).~/.hermes/profiles/<name>/skills/first. Only falls back to the global~/.hermes/skills/if the profile dir is missing or skills are not found.Changes
tools/skills_tool.py: Added_get_profile_skills_dir()helper and updated_find_all_skills().agent/skill_commands.py: Updatedscan_skill_commands()to prioritize profile-specific skills.Motivation
Currently, Hermes loads skills globally. In a multi-agent architecture:
architectagent doesn't needmarketing-douyin-strategist.mainagent doesn't needsystematic-debuggingorvLLM.Separating them reduces context window usage and enforces strict role boundaries.