fix(gateway): keep empty gateway responses silent - #23672
Open
LeonSGP43 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for isolating the gateway delivery concern. The branch needs substantial rework against current main. Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keeps gateway chat channels silent when the agent ends a turn with no user-facing text.
The gateway currently turns empty results into backend-style warning text like
(empty)fallbacks or synthetic failure messages. That makes valid silent outcomes look broken in shared chats. This change keeps those diagnostics internal for gateway delivery while preserving the existing helper behavior for non-gateway callers.Related Issue
Fixes #22712
Type of Change
Changes Made
(empty)sentinels into user-visible warning text ingateway/run.py_normalize_empty_agent_response(...)unchanged by default for other callerstests/test_lazy_session_regressions.pyfor silent gateway-mode failed/partial empty turnsHow to Test
uv run --frozen --extra dev pytest -q -o addopts='' tests/test_lazy_session_regressions.pyuv run --frozen ruff check gateway/run.py tests/test_lazy_session_regressions.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
uv run --frozen --extra dev pytest -q -o addopts='' tests/test_lazy_session_regressions.py->19 passeduv run --frozen ruff check gateway/run.py tests/test_lazy_session_regressions.py->All checks passed!