-
Notifications
You must be signed in to change notification settings - Fork 52.1k
fix(auxiliary): support minimax oauth providers #23639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LeonSGP43
wants to merge
1
commit into
NousResearch:main
Choose a base branch
from
LeonSGP43:codex/21521-minimax-oauth-aux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25
β2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2497,6 +2497,25 @@ def test_resolve_provider_client_passes_explicit_api_key_to_anthropic(self): | |
| "resolve_provider_client must forward explicit_api_key to _try_anthropic()" | ||
| ) | ||
|
|
||
| def test_resolve_provider_client_supports_minimax_oauth(self): | ||
| """MiniMax OAuth should resolve via its runtime credential helper.""" | ||
| fake_client = MagicMock() | ||
| with patch( | ||
| "hermes_cli.auth.resolve_minimax_oauth_runtime_credentials", | ||
| return_value={ | ||
| "provider": "minimax-oauth", | ||
| "api_key": "oauth-token", | ||
| "base_url": "https://api.minimax.io/anthropic", | ||
| "source": "oauth", | ||
| }, | ||
| ), patch("agent.auxiliary_client.OpenAI", return_value=fake_client) as mock_openai: | ||
| client, model = resolve_provider_client("minimax-oauth") | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid asserting a provider-default model literal here: current |
||
| assert client is not None | ||
| assert model == "MiniMax-M2.7-highspeed" | ||
| assert mock_openai.call_args.kwargs["api_key"] == "oauth-token" | ||
| assert mock_openai.call_args.kwargs["base_url"] == "https://api.minimax.io/v1" | ||
|
|
||
|
|
||
| # ββ Auxiliary unhealthy-provider TTL cache (issue #23570) ββββββββββββββββ | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve MiniMax credentials with
as_token_provider=Trueand preserve the resulting callable rather than flowing it into the followingstr(...)coercion. Currenthermes_cli/auth.py:7759-7791documents that this is required to refresh MiniMax's short-lived OAuth access token per request.