fix(cli): mark sessions command as cli_only - #23577
Closed
AllynSheep wants to merge 1 commit into
Closed
Conversation
The /sessions slash command is registered in COMMAND_REGISTRY but has no handler in either gateway/run.py or cli.py. This causes a silent no-op — users send /sessions and get zero response. Mark the command as cli_only=True so it is excluded from GATEWAY_KNOWN_COMMANDS. The interactive session browser requires keyboard navigation and is not feasible in messaging gateways. Fixes NousResearch#23533
Collaborator
This was referenced May 11, 2026
Contributor
|
Thanks for identifying the original Automated hermes-sweeper review found that current
Marking the command CLI-only would now suppress that supported gateway behavior, so this PR is superseded by main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/sessionsslash command is registered inCOMMAND_REGISTRYbut has no handler in either the gateway dispatcher or the CLI dispatcher. It results in a silent no-op — the user sends/sessionsand gets zero response.Fix
Mark
sessionsascli_only=Trueso it is excluded fromGATEWAY_KNOWN_COMMANDS. The interactive session browser requires keyboard navigation and is not feasible in messaging gateways.Changes
hermes_cli/commands.py: Addedcli_only=Truetosessionscommand definitionTesting
hermes sessions browsecontinues to work in CLI mode/sessionswith unknown command handlingCloses #23533